Author mgiuca
Recipients ezio.melotti, kcwu, loewis, mgiuca, sandberg
Date 2009-11-19.00:39:28
SpamBayes Score 0.000109266
Marked as misclassified No
Message-id <1258591170.63.0.403551861757.issue5827@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks Ezio.

I've updated the patch to incorporate your suggestions.

Note that I too have only tested it on Linux, but I tested both
posixpath and ntpath (and there is no OS-specific code, except for the
filenames themselves).

I'm not sure if using assertTrue(isinstance ...) is better than
assertEqual(type ...), because the type equality checking produces this
error:
AssertionError: <type 'str'> != <type 'unicode'>
while isinstance produces this unhelpful error:
AssertionError: False is not True

But oh well, I made the change anyway as most test cases use isinstance.
History
Date User Action Args
2009-11-19 00:39:30mgiucasetrecipients: + mgiuca, loewis, kcwu, ezio.melotti, sandberg
2009-11-19 00:39:30mgiucasetmessageid: <1258591170.63.0.403551861757.issue5827@psf.upfronthosting.co.za>
2009-11-19 00:39:29mgiucalinkissue5827 messages
2009-11-19 00:39:29mgiucacreate