➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gregory.p.smith
Recipients Rhamphoryncus, giampaolo.rodola, gregory.p.smith, hgibson50, jcea, kevinwatters, pitrou, sserrano, vstinner
Date 2009-11-07.07:48:06
SpamBayes Score 0.14046165
Marked as misclassified No
Message-id <00163691fe1f3ed1760477c32e9c@google.com>
In-reply-to
Content 
Reviewers: ,

http://codereview.appspot.com/150055/diff/1/4
File Modules/_threadmodule.c (right):

http://codereview.appspot.com/150055/diff/1/4#newcode221
Modules/_threadmodule.c:221: return PyBool_FromLong((long) r);
This explicit (long) cast is unnecessary.

http://codereview.appspot.com/150055/diff/1/4#newcode246
Modules/_threadmodule.c:246: PyThread_release_lock(self->rlock_lock);
reset self->rlock_owner to 0 before releasing the lock.

Description:
code review for http://bugs.python.org/issue3001

Please review this at http://codereview.appspot.com/150055

Affected files:
   M     Lib/test/test_threading.py
   M     Lib/threading.py
   M     Modules/_threadmodule.c
History
Date User Action Args
2009-11-07 07:48:08gregory.p.smithsetrecipients: + jcea, Rhamphoryncus, pitrou, hgibson50, vstinner, giampaolo.rodola, kevinwatters, sserrano
2009-11-07 07:48:07gregory.p.smithlinkissue3001 messages
2009-11-07 07:48:06gregory.p.smithcreate