Author pitrou
Recipients ggenellina, pitrou, tercero12
Date 2009-11-04.01:26:14
SpamBayes Score 3.17519e-08
Marked as misclassified No
Message-id <1257297976.55.0.671427371856.issue4969@psf.upfronthosting.co.za>
In-reply-to
Content
A couple of points:
- if the method is Windows-specific, I don't think it shouldn't bear a
name as generic as "read_registry()". There are "registries" on other
systems.
- the method should probably raise early on non-Windows systems (raise
NotImplementedError?)
- please fix the coding style; don't collapse a "try", "except" or
"finally" and the following statement on a single line
- in the tests, rather than defining an empty test case on non-Windows
systems, make the tests skip (for example, call self.skipTest()
History
Date User Action Args
2009-11-04 01:26:23pitrousetrecipients: + pitrou, ggenellina, tercero12
2009-11-04 01:26:16pitrousetmessageid: <1257297976.55.0.671427371856.issue4969@psf.upfronthosting.co.za>
2009-11-04 01:26:15pitroulinkissue4969 messages
2009-11-04 01:26:14pitroucreate