Author pitrou
Recipients belopolsky, brett.cannon, eric.smith, gregory.p.smith, larry, nnorwitz, pitrou
Date 2009-10-29.11:34:06
SpamBayes Score 1.55482e-07
Marked as misclassified No
Message-id <1256816048.75.0.521051944087.issue5872@psf.upfronthosting.co.za>
In-reply-to
Content
This patch is huge.

Some things:
- you should provide an example of using the new API. Your description
is not very, well, descriptive :)
- "all PyTypeObjects must now be *pointers* rather than static
instances": is it mandatory, or did you add this out of "purity"? It
would be nice if we could minimize disruption (that is, provide the new
API as a feature, but not force ourselves and other people to rewrite
huge chunks of code)
- same for the private declaration of PyTypeObject: is it really
necessary to hide it from outside code?

Lastly, since your patch is not ready for consumption, I would advocate
creating a branch somewhere (on the SVN sandbox if you have access
rights, or in a separate e.g. bitbucket repository by cloning the
existing Mercurial mirror).
History
Date User Action Args
2009-10-29 11:34:09pitrousetrecipients: + pitrou, nnorwitz, brett.cannon, gregory.p.smith, belopolsky, larry, eric.smith
2009-10-29 11:34:08pitrousetmessageid: <1256816048.75.0.521051944087.issue5872@psf.upfronthosting.co.za>
2009-10-29 11:34:07pitroulinkissue5872 messages
2009-10-29 11:34:06pitroucreate