Author giampaolo.rodola
Recipients giampaolo.rodola, gregory.p.smith, iElectric, janssen, jeffo, josiah.carlson, josiahcarlson, lgedgar, lszyba1, pitrou, qwavel, roberte, twhitema
Date 2009-10-19.19:02:29
SpamBayes Score 6.31949e-07
Marked as misclassified No
Message-id <1255978951.34.0.343923165673.issue2054@psf.upfronthosting.co.za>
In-reply-to
Content
> Ah, sorry, roundup's e-mail interface ate part of the message.
> The error happens when doing "from ftplib import *". Apparently 
__all__
> contains a non-string value.

Oh, shame on me! You're right.
Thanks for the great review you're doing.

> Regarding msg64093, the only API change Bill's suggestion would entail
> is an additional optional parameter to the constructor, so adding it
> later would be backwards-compatible.

Good.
Possibly there might be another change we might want to do in future, 
which is adding support for CCC command, useful for reverting the 
control connection back to clear-text.
I remember I tried to do that at the time I submitted the first patch 
but there was a problem with ssl's unwrap() method (I really don't 
remember what exactly).

Anyway, I'll try to put hands on that soon and let you know what 
happens.
The change should be backward compatible as it just consists in adding a 
ccc() method.
History
Date User Action Args
2009-10-19 19:02:31giampaolo.rodolasetrecipients: + giampaolo.rodola, gregory.p.smith, josiahcarlson, janssen, pitrou, josiah.carlson, roberte, iElectric, lszyba1, twhitema, jeffo, qwavel, lgedgar
2009-10-19 19:02:31giampaolo.rodolasetmessageid: <1255978951.34.0.343923165673.issue2054@psf.upfronthosting.co.za>
2009-10-19 19:02:29giampaolo.rodolalinkissue2054 messages
2009-10-19 19:02:29giampaolo.rodolacreate