Author giampaolo.rodola
Recipients giampaolo.rodola, gregory.p.smith, iElectric, janssen, jeffo, josiah.carlson, josiahcarlson, lgedgar, lszyba1, pitrou, qwavel, roberte, twhitema
Date 2009-10-19.12:55:12
SpamBayes Score 1.63361e-08
Marked as misclassified No
Message-id <1255956920.42.0.212039084217.issue2054@psf.upfronthosting.co.za>
In-reply-to
Content
> You can build the docs by going to the Doc directory and typing "make
> html" there. It isn't critical anyway.

Done. It's well formatted now.

> The tests failed to run, I had to replace the KEYCERT declaration with:
>    KEYCERT = os.path.join(os.path.dirname(__file__), "keycert.pem") 
> (and add "import os" at the top)

Done.


> Another remark: login() doesn't return the response, while it does on
> the normal FTP class.

Good catch, thanks. 
Done.

> Apart from that, I'm trying to test on a TLS-enabled FTP server, but
> even the regular FTP class doesn't seem to work with it (I get "500
> Illegal PORT command" when calling retrlines('LIST')).

Strange. I doubt this issue is related with my changes.
I tried FTP_TLS agains proftpd, filezilla server and pyftpdlib and it
works fine.

New patch in attachment btw.
History
Date User Action Args
2009-10-19 12:55:20giampaolo.rodolasetrecipients: + giampaolo.rodola, gregory.p.smith, josiahcarlson, janssen, pitrou, josiah.carlson, roberte, iElectric, lszyba1, twhitema, jeffo, qwavel, lgedgar
2009-10-19 12:55:20giampaolo.rodolasetmessageid: <1255956920.42.0.212039084217.issue2054@psf.upfronthosting.co.za>
2009-10-19 12:55:18giampaolo.rodolalinkissue2054 messages
2009-10-19 12:55:17giampaolo.rodolacreate