Message94103
From a quick look at the patch, if you call login() twice, the socket
will be wrapped twice as well? Perhaps auth_tls() should have a
protection against this.
In prot_p() and prot_c(), it seems that self._prot_p is updated
unconditionally, regardless of the FTP response.
In retrbinary(), retrlines(), storbinary() and storlines(), you
certainly want some try/finally blocks so that the data connection
always gets closed at the end. |
|
Date |
User |
Action |
Args |
2009-10-15 18:27:38 | pitrou | set | recipients:
+ pitrou, gregory.p.smith, janssen, giampaolo.rodola, roberte, iElectric, lszyba1, twhitema, jeffo, qwavel, lgedgar |
2009-10-15 18:27:38 | pitrou | set | messageid: <1255631258.19.0.73560968745.issue2054@psf.upfronthosting.co.za> |
2009-10-15 18:27:36 | pitrou | link | issue2054 messages |
2009-10-15 18:27:36 | pitrou | create | |
|