Author ronaldoussoren
Recipients ronaldoussoren, zvezdan
Date 2009-09-15.21:10:57
SpamBayes Score 4.15835e-09
Marked as misclassified No
Message-id <1253049061.85.0.0724569698473.issue6877@psf.upfronthosting.co.za>
In-reply-to
Content
The attached patch is a slightly cleaner version of your patch. What I 
don't like is that I'm also using runtime detection of libedit, I'd 
prefer compile-time detection but that doesn't seem possible without 
doing that dtection in setup.py.

My changes w.r.t. your patch:
* Do the libedit detection once when the readline module is initialised.
* Place libedit support in "#ifdef __APPLE__" blocks, the code might
  work with other libedit's (such as the one in NetBSD) as well, 
  but I cannot test that and don't want to risk breaking other 
  platforms.
* Also patch readline.get_history_item
* Change readline.__doc__ when using libedit's readline emulation

The patch seems to work on fine, including browsing in ipython's history 
on 10.6.

PS. I mentioned ipython because I know there were issues with ipython 
and Apple's python when Leopard was just out. I don't use ipython myself 
and hence don't know if they have added workarounds in their code (or if 
Apple fixed the issues the ran into)

Marking this issue as 'needs review' for two reasons:
1) I'm not familiar with the readline code
2) I'd like to know if this patch is backport material
History
Date User Action Args
2009-09-15 21:11:01ronaldoussorensetrecipients: + ronaldoussoren, zvezdan
2009-09-15 21:11:01ronaldoussorensetmessageid: <1253049061.85.0.0724569698473.issue6877@psf.upfronthosting.co.za>
2009-09-15 21:10:59ronaldoussorenlinkissue6877 messages
2009-09-15 21:10:59ronaldoussorencreate