Message 92476 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	boya, loewis, vstinner
Date	2009-09-10.09:03:23
SpamBayes Score	1.772507e-06
Marked as misclassified	No
Message-id	<1252573405.03.0.794294146738.issue6873@psf.upfronthosting.co.za>
In-reply-to

Content
The patch is incorrect. Why do you think there is an overflow? There is none in the call to ParseTuple: the i argument parser expects a signed int; passing a long will break on systems where sizeof(int)!=sizeof(long) (such as typical 64-bit Unix). In addition, the actual overflow in the current code (casting to uid_t) is not handled in the patch.

The patch is incorrect. Why do you think there is an overflow? There is 
none in the call to ParseTuple: the i argument parser expects a signed 
int*; passing a long* will break on systems where 
sizeof(int)!=sizeof(long) (such as typical 64-bit Unix).

In addition, the *actual* overflow in the current code (casting to uid_t) 
is not handled in the patch.

History
Date	User	Action	Args
2009-09-10 09:03:25	loewis	set	recipients: + loewis, vstinner, boya
2009-09-10 09:03:25	loewis	set	messageid: <1252573405.03.0.794294146738.issue6873@psf.upfronthosting.co.za>
2009-09-10 09:03:24	loewis	link	issue6873 messages
2009-09-10 09:03:23	loewis	create