Author nirs
Recipients giampaolo.rodola, josiahcarlson, nirs
Date 2009-08-03.12:19:53
SpamBayes Score 6.39965e-10
Marked as misclassified No
Message-id <1249301995.86.0.0156921921481.issue6550@psf.upfronthosting.co.za>
In-reply-to
Content
handle_expt is documented to be called when there is OOB data. However,
handle_expt_event is not documented, and according the framework design
as I see it, it simply means "socket has exceptional condition" when
select returns. On unix, this means there is oob data, and on Windows,
it means "there is some error".

This works exactly the same for handle_read_event and handle_write_event
- they may be called on connection refused error. Checking for errors in
handle_expt_event is the right thing to do, and allow you to avoid the
ugly checks and double try..except in _exception.

If you want handle_foo_event to be called only on foo events, then they
will not have anything to do except calling handle_foo. This is actually
the case now in handle_expt_event. I don't see any advantage of this
design change.
History
Date User Action Args
2009-08-03 12:19:55nirssetrecipients: + nirs, josiahcarlson, giampaolo.rodola
2009-08-03 12:19:55nirssetmessageid: <1249301995.86.0.0156921921481.issue6550@psf.upfronthosting.co.za>
2009-08-03 12:19:54nirslinkissue6550 messages
2009-08-03 12:19:53nirscreate