This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author taleinat
Recipients gpolo, kbk, taleinat
Date 2009-08-02.19:22:17
SpamBayes Score 9.212154e-08
Marked as misclassified No
Message-id <1249240939.5.0.847143178387.issue2053@psf.upfronthosting.co.za>
In-reply-to
Content
The whole point of this patch is to make the EditorWindow's Text widget
the default master/parent for its dialogs!

IMO this makes sense, since this is a reasonable and intuitive default
for such methods of the EditorWindow object. I understand the "explicit
is better than implicit" argument, but that doesn't mean that having a
reasonable default value is always wrong. In this case having a default
value both simplifies the code considerably and makes sense, so IMO it
is justified.


Also, please note that the patch actually reduces the size of
EditorWindow.py (both character and line counts) and cleans up the code
in many places. Yes, the definition of the relevant methods is not
trivial, but it is in just one area of the code.
History
Date User Action Args
2009-08-02 19:22:19taleinatsetrecipients: + taleinat, kbk, gpolo
2009-08-02 19:22:19taleinatsetmessageid: <1249240939.5.0.847143178387.issue2053@psf.upfronthosting.co.za>
2009-08-02 19:22:18taleinatlinkissue2053 messages
2009-08-02 19:22:18taleinatcreate