Message91165
handle_expt_event was removed in the test classes because it is no
longer being used by any of the tests. None of them send OOB data (also
known as priority data), so handle_expt_event should never be called.
When I have a chance to compare your patch to mine (Monday, likely),
I'll comment then.
In terms of "handle_expt_event should handle the low level expt event
called from select", what you don't seem understand is that and "expt
event" is not an exception event, it's a "we got OOB data" event, and
with the patches, it is called at *exactly* the time it should be: when
there is OOB data. It used to be mistakenly called in the select loop
whenever any sort of non-normal condition happened on the socket, which
was a serious design flaw, and lead to significant misunderstanding
about the purpose of the method.
With the _exception() call as-is, it now behaves like the
asyncore.poll2() function, which is the right thing. |
|
Date |
User |
Action |
Args |
2009-08-01 17:49:22 | josiahcarlson | set | recipients:
+ josiahcarlson, nirs, giampaolo.rodola |
2009-08-01 17:49:22 | josiahcarlson | set | messageid: <1249148962.64.0.300674644941.issue6550@psf.upfronthosting.co.za> |
2009-08-01 17:49:21 | josiahcarlson | link | issue6550 messages |
2009-08-01 17:49:20 | josiahcarlson | create | |
|