Message91155
I tested asyncore_fix_refused-3.patch on Mac OS X 10.5 - all asyncore
and asynchat tests pass.
There is one minor issue - _exception calls the non existing
handle_close_event instead of handle_close.
However, looking again at the code I think that it is ugly and wrong -
handle_expt_event should handle the low level expt event called from
select, allowing third party dispatcher to override the behavior as
needed.
Another issue - lately, a new event was added - handle_connect_event -
this is wrong! there is no such low level event. handle_connect is a
high level event, implied by first read or write on the connecting
socket. This event will break 3rd party dispatcher that does not
implement it, and is not documented. |
|
Date |
User |
Action |
Args |
2009-07-31 23:21:07 | nirs | set | recipients:
+ nirs, josiahcarlson, giampaolo.rodola |
2009-07-31 23:21:07 | nirs | set | messageid: <1249082467.52.0.102396191094.issue6550@psf.upfronthosting.co.za> |
2009-07-31 23:21:05 | nirs | link | issue6550 messages |
2009-07-31 23:21:05 | nirs | create | |
|