Author josiahcarlson
Recipients josiahcarlson, nirs
Date 2009-07-28.20:23:31
SpamBayes Score 1.80522e-05
Marked as misclassified No
Message-id <1248812614.17.0.183921522706.issue6550@psf.upfronthosting.co.za>
In-reply-to
Content
Firstly, it expects that handle_expt_event() is for handling exceptional 
conditions.  This is not the case.  handle_expt_event() is meant for 
handling "OOB" or "priority" data coming across a socket.  FTP and some 
other protocols use this.  I forgot to fix it earlier, which is why it's 
making it into this patch.

Secondly, I pulled the part that was inside handle_expt_event() that was 
being used to find the exception and pulls it out into _exception(), 
removing the previous behavior (wrt to the broken API), and replacing it 
with something that is cleaner and more correct (assuming sockets).

To respond to it being an issue that the object has a socket with a 
getsockopt(), I can fix it to handle the AttributeError case.

Would you be willing to try this out given my explanation as to why I 
changed your patch?
History
Date User Action Args
2009-07-28 20:23:34josiahcarlsonsetrecipients: + josiahcarlson, nirs
2009-07-28 20:23:34josiahcarlsonsetmessageid: <1248812614.17.0.183921522706.issue6550@psf.upfronthosting.co.za>
2009-07-28 20:23:33josiahcarlsonlinkissue6550 messages
2009-07-28 20:23:32josiahcarlsoncreate