Author r.david.murray
Recipients conf, exarkun, r.david.murray
Date 2009-06-01.11:45:16
SpamBayes Score 2.31984e-06
Marked as misclassified No
Message-id <1243856720.82.0.944572115621.issue5230@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks.  The unit tests don't pass, though, at least not when I apply
the patch to trunk.  I get three failures.  So the patch isn't correct
as it stands.  'path' is the full module path (test.i_am_not_here in the
case of one of the test failures), but what appears in the error message
is just the name of the module that wasn't found.

Also consider the case where the import is 'import some.nested.module',
and the module that isn't found is 'nested'.  In fact it may be worth
writing an additional test for that case.

Also I'd recommend renaming badimport_module.py pydoc_badimport.py so as
to be parallel to the other pydoc auxiliary test files.
History
Date User Action Args
2009-06-01 11:45:21r.david.murraysetrecipients: + r.david.murray, exarkun, conf
2009-06-01 11:45:20r.david.murraysetmessageid: <1243856720.82.0.944572115621.issue5230@psf.upfronthosting.co.za>
2009-06-01 11:45:19r.david.murraylinkissue5230 messages
2009-06-01 11:45:17r.david.murraycreate