Message87845
BaseServer.shutdown is documented as "Tells the serve_forever() loop to
stop and waits until it does."
The docstring is much more explicit: """Stops the serve_forever loop.
Blocks until the loop has finished. This must be called while
serve_forever() is running in another thread, or it will deadlock."""
Combined with #2302 I'd rewrite both (rst and docstring) as:
BaseServer.shutdown(): Tells the serve_forever() loop to stop, and
waits until the loop has finished. This must be called after
serve_forever() has started and while it is running in another thread,
or the shutdown() call will deadlock." |
|
Date |
User |
Action |
Args |
2009-05-15 23:57:57 | ggenellina | set | recipients:
+ ggenellina, georg.brandl |
2009-05-15 23:57:56 | ggenellina | set | messageid: <1242431876.91.0.139343855315.issue6031@psf.upfronthosting.co.za> |
2009-05-15 23:57:55 | ggenellina | link | issue6031 messages |
2009-05-15 23:57:55 | ggenellina | create | |
|