Message87690
"""I assume these changes were made to silence warnings from
-Wstrict-overflow, but I don't think that should be a goal:
I'd suggest only making changes where there's a genuine
possibility of overflow (even if it's a remote one), and
leaving the code unchanged if it's reasonably easy to
see that overflow is impossible."""
There is a lot of value in being able to compile with -Wstrict-overflow
and know that every warning omitted is something to be looked at. I
think it is advantageous to make all code pass this. Having any
"expected" warnings during compilation tends to lead people to ignore
all warnings.
That said, I agree those particular examples of unnecessary casts are
ugly and should be written differently if they are actually done to
prevent a warning. |
|
Date |
User |
Action |
Args |
2009-05-13 16:01:10 | gregory.p.smith | set | recipients:
+ gregory.p.smith, gvanrossum, loewis, nnorwitz, mark.dickinson, pitrou, vstinner, christian.heimes, alexandre.vassalotti, donmez, matejcik |
2009-05-13 16:01:09 | gregory.p.smith | set | messageid: <1242230469.85.0.373271661283.issue1621@psf.upfronthosting.co.za> |
2009-05-13 16:01:08 | gregory.p.smith | link | issue1621 messages |
2009-05-13 16:01:07 | gregory.p.smith | create | |
|