This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients cdavid, loewis
Date 2009-05-06.07:38:29
SpamBayes Score 2.26835e-11
Marked as misclassified No
Message-id <4A013E6C.80700@v.loewis.de>
In-reply-to <1241588046.15.0.223439230568.issue4709@psf.upfronthosting.co.za>
Content
> The toolchain is difficult to build, but the patch is easy to review, it
> just moves the MS_WIN64 outside the MS compiler specific part. If it
> does not break the MS toolchain (the one used to build the official
> python), I don't see the problem.

As a principle, I always try to reproduce a problem when reviewing a
patch. In many cases, doing so reveals insights into the actual problem,
and leads to a different patch.

That the patch is "harmless" is not a convincing reason to apply it.

> I can make the toolchain available to you as a tarball, though, so that
> you can easily test from a windows command shell without having to
> install anything.

That would be nice.
History
Date User Action Args
2009-05-06 07:38:31loewissetrecipients: + loewis, cdavid
2009-05-06 07:38:30loewislinkissue4709 messages
2009-05-06 07:38:29loewiscreate