Author eric.smith
Recipients amaury.forgeotdarc, eric.smith, larry, mhammond, paul.moore
Date 2009-05-05.00:50:06
SpamBayes Score 7.11211e-10
Marked as misclassified No
Message-id <1241484609.84.0.369968967488.issue5799@psf.upfronthosting.co.za>
In-reply-to
Content
> I've generated a new patch, attached.  I don't know why you had trouble
> applying.

Yeah, I'm not sure what that was about. Part of the patch applied, but
not the rest. In any event, the current one applied cleanly.

I'm not sure this part of the patch is correct (in relpath):
     for i in range(min(len(start_list), len(path_list))):
-        if start_list[i].lower() != path_list[i].lower():
+        if start_list[i] != path_list[i]:
             break
-    else:
         i += 1

I think removing the "else:" is likely an error. It probably also means
that this code isn't tested.

Other than that, this looks reasonable enough to me. I'm hoping someone
else can give it a thorough review, too. I haven't had time to look
through all of the cases in join() to verify that they're correct and
complete.
History
Date User Action Args
2009-05-05 00:50:10eric.smithsetrecipients: + eric.smith, mhammond, paul.moore, amaury.forgeotdarc, larry
2009-05-05 00:50:09eric.smithsetmessageid: <1241484609.84.0.369968967488.issue5799@psf.upfronthosting.co.za>
2009-05-05 00:50:08eric.smithlinkissue5799 messages
2009-05-05 00:50:06eric.smithcreate