Author bquinlan
Recipients bquinlan, pitrou
Date 2009-04-18.07:41:32
SpamBayes Score 1.315e-06
Marked as misclassified No
Message-id <001485f54658f46b8f0467cf6cf8@google.com>
In-reply-to
Content
http://codereview.appspot.com/40126/diff/1/2
File Lib/_pyio.py (left):

http://codereview.appspot.com/40126/diff/1/2#oldcode370
Line 370: def _checkReadable(self, msg=None):
On 2009/04/17 21:11:15, Antoine Pitrou wrote:
> Not sure why you're removing it. Currently it's used in Lib/socket.py.

I didn't see the other usages. I removed it because it was only used
twice in this file and one of the usages involved an instance other than
self i.e. calling an internal method on another instance. Ditto for
_checkWriteable

Now restored.

http://codereview.appspot.com/40126/diff/1/3
File Lib/test/test_io.py (right):

http://codereview.appspot.com/40126/diff/1/3#newcode1121
Line 1121: self.assertTrue(pair.readable)
On 2009/04/17 21:11:15, Antoine Pitrou wrote:
> This is probably `pair.readable()` and not `pair.readable`.

Done.

http://codereview.appspot.com/40126/diff/1/3#newcode1125
Line 1125: self.assertTrue(pair.writable)
On 2009/04/17 21:11:15, Antoine Pitrou wrote:
> Same comment as for readable above.

Done.

http://codereview.appspot.com/40126/diff/1/3#newcode1126
Line 1126:
On 2009/04/17 21:11:15, Antoine Pitrou wrote:
> There should probably be a test for seekable() as well.

Now you are getting greedy. Done.

http://codereview.appspot.com/40126/diff/1/4
File Modules/_io/bufferedio.c (right):

http://codereview.appspot.com/40126/diff/1/4#newcode1876
Line 1876: Py_DECREF(self->reader);
On 2009/04/17 21:11:15, Antoine Pitrou wrote:
> You must use Py_CLEAR so that there is no double free when calling
> BufferedRWPair_dealloc().

Done.

http://codereview.appspot.com/40126
History
Date User Action Args
2009-04-18 07:41:34bquinlansetrecipients: + bquinlan
2009-04-18 07:41:33bquinlanlinkissue5734 messages
2009-04-18 07:41:32bquinlancreate