Message84771
Well, I think your patch has some issues.
>>> import mmap
>>> m = mmap.mmap(-1, 10)
>>> m.move(10, 10, 0) # legal, should not fail
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: source out of range
>>> m.move(9, 9, -1) # should not crash
(crash)
I hesitated to commit my patch because mmap.move is using unsigned long,
but I thought it should use size_t or Py_ssize_t (If mmap should
represent total memory area, it may have to use size_t, but maybe it
should use Py_ssize_t as well as other python modules like string)
Anyway, I'll commit my patch before Python2.6.2 will be released. Crash
is not good thing for any time. :-) |
|
Date |
User |
Action |
Args |
2009-03-31 13:05:42 | ocean-city | set | recipients:
+ ocean-city, jackdied |
2009-03-31 13:05:42 | ocean-city | set | messageid: <1238504742.11.0.703971977141.issue5387@psf.upfronthosting.co.za> |
2009-03-31 13:05:40 | ocean-city | link | issue5387 messages |
2009-03-31 13:05:40 | ocean-city | create | |
|