Author vstinner
Recipients LambertDW, amaury.forgeotdarc, ocean-city, vstinner
Date 2009-03-17.23:40:58
SpamBayes Score 0.000575569
Marked as misclassified No
Message-id <1237333260.92.0.477095906943.issue2382@psf.upfronthosting.co.za>
In-reply-to
Content
Comments about my own patches.

unicode_width.patch: 

* error messages should be improved:
  ValueError("Unable to compute string width") for Windows
  IOError(strerror(errno)) otherwise

adjust_offset.patch: 

* format_exception_only() from Lib/traceback.py may need a fix
* about the documentation: it looks like SyntaxError.offset unit is 
not documentation in exceptions.rst (should it be documented, or 
leaved unchanged?)

print_exception.patch:

* i'm not sure of the reference counts (ref leak?)
* in case of PyUnicode_FromUnicode(text, textlen) error, 
>>PyFile_WriteObject(textobj, f, Py_PRINT_RAW); 
PyFile_WriteString("\n", f);<< is used to display the line but textobj 
may already ends with \n.
* format_exception_only() from Lib/traceback.py should do the same job 
than fixed print_exception(): get the string width (to fix this 
issue!)
History
Date User Action Args
2009-03-17 23:41:01vstinnersetrecipients: + vstinner, amaury.forgeotdarc, ocean-city, LambertDW
2009-03-17 23:41:00vstinnersetmessageid: <1237333260.92.0.477095906943.issue2382@psf.upfronthosting.co.za>
2009-03-17 23:40:59vstinnerlinkissue2382 messages
2009-03-17 23:40:59vstinnercreate