Message83707
While we're cleaning up:
data = child.data
if not data:
could be
if not child.data:
since data is not used again.
Alternatively, you could use data in place of child.data later on for a
small speed-up, but I doubt that we care about such small optimizations
here. If we do, then we should also assign a name to child.nextSibling,
though.
I found the three-line duplication between the two branches mildly
refactor-worthy, but when I eliminated it the control logic got more
involved and I don't think that's a good trade-off here. |
|
Date |
User |
Action |
Args |
2009-03-17 22:58:36 | maltehelmert | set | recipients:
+ maltehelmert, akuchling, r.david.murray |
2009-03-17 22:58:36 | maltehelmert | set | messageid: <1237330716.25.0.428216750528.issue2170@psf.upfronthosting.co.za> |
2009-03-17 22:58:34 | maltehelmert | link | issue2170 messages |
2009-03-17 22:58:34 | maltehelmert | create | |
|