Message83681
I eyeballed the new patch and wonder if the case where text nodes are
collapsed is handled correctly. Assume that self.childNodes contains
nodes [A, B, C], where A and B are non-empty text nodes and C is a
non-text node.
The algorithm would collapse A and B into A and then unlink B, and I
think C.previousSibling would still reference the unlinked B, rather
than the correct A. Am I missing something?
If this is indeed a bug in the proposed patch, I suggest adding an
additional test for this case.
The bug itself should not be too hard to fix; the "elif" case would need
the same
if child.nextSibling:
child.nextSibling.previousSibling = child.previousSibling
assignment as the "if" case. |
|
Date |
User |
Action |
Args |
2009-03-17 16:05:52 | maltehelmert | set | recipients:
+ maltehelmert, akuchling, r.david.murray |
2009-03-17 16:05:51 | maltehelmert | set | messageid: <1237305951.76.0.0282172351633.issue2170@psf.upfronthosting.co.za> |
2009-03-17 16:05:45 | maltehelmert | link | issue2170 messages |
2009-03-17 16:05:45 | maltehelmert | create | |
|