Message83498
I tried using TestSkipped first, but since I was throwing it from an
individual testcase and not from the top level, it still showed up as an
error in test_tcl (I may have done it wrong, of course).
Moving the tests makes more sense anyway, so I've revised my patch to do
that. I didn't move all of the tests because as far as I could
understand the test.test_tk code, if I moved them all they'd only get
run if the GUI resource was enabled, and that seems wrong. So I just
moved the tests that specifically involved tk.
I ran the test suite under a variety of DISPLAY settings and
non-settings, and it seemed to do the right thing with the patch
applied. I have pushed the change up to Launchpad as well. |
|
Date |
User |
Action |
Args |
2009-03-12 16:21:48 | r.david.murray | set | recipients:
+ r.david.murray, gpolo |
2009-03-12 16:21:48 | r.david.murray | set | messageid: <1236874908.28.0.960430419179.issue5450@psf.upfronthosting.co.za> |
2009-03-12 16:21:46 | r.david.murray | link | issue5450 messages |
2009-03-12 16:21:46 | r.david.murray | create | |
|