Author benjamin.peterson
Recipients ajaksu2, amaury.forgeotdarc, benjamin.peterson, christian.heimes, exarkun, giampaolo.rodola, gregory.p.smith, ialbert, pitrou, rhettinger, wplappert
Date 2009-03-03.21:47:42
SpamBayes Score 9.0429e-05
Marked as misclassified No
Message-id <1afaf6160903031347y4c6d410fr6666927453be791f@mail.gmail.com>
In-reply-to <0016361649e7059a0f04643d5acd@google.com>
Content
2009/3/3 Daniel Diniz <report@bugs.python.org>:
> A couple of typos in the Python implementation.

Thanks for taking a look! Fixed these things in r70135.

> http://codereview.appspot.com/22061/diff/1/11#newcode844
> Line 844: self._reset_read_buf()
> Setting "_read_buf" and "_read_pos" directly on __init__ may help
> introspection tools.

Perhaps, but I think it duplicates too much of _reset_read_buf(). And
it wouldn't damage introspection, just static analysis.

> http://codereview.appspot.com/22061/diff/1/11#newcode1728
> Line 1728: decoder = self._decoder or self._get_decoder()
> 'decoder' isn't used in this method, is this here for an useful
> side-effect?

Yes, it's for side affect, but it needn't be in a variable.
History
Date User Action Args
2009-03-03 21:47:44benjamin.petersonsetrecipients: + benjamin.peterson, rhettinger, gregory.p.smith, exarkun, amaury.forgeotdarc, pitrou, giampaolo.rodola, christian.heimes, ajaksu2, wplappert, ialbert
2009-03-03 21:47:43benjamin.petersonlinkissue4565 messages
2009-03-03 21:47:42benjamin.petersoncreate