Message83106
2009/3/3 Daniel Diniz <report@bugs.python.org>:
> A couple of typos in the Python implementation.
Thanks for taking a look! Fixed these things in r70135.
> http://codereview.appspot.com/22061/diff/1/11#newcode844
> Line 844: self._reset_read_buf()
> Setting "_read_buf" and "_read_pos" directly on __init__ may help
> introspection tools.
Perhaps, but I think it duplicates too much of _reset_read_buf(). And
it wouldn't damage introspection, just static analysis.
> http://codereview.appspot.com/22061/diff/1/11#newcode1728
> Line 1728: decoder = self._decoder or self._get_decoder()
> 'decoder' isn't used in this method, is this here for an useful
> side-effect?
Yes, it's for side affect, but it needn't be in a variable. |
|
Date |
User |
Action |
Args |
2009-03-03 21:47:44 | benjamin.peterson | set | recipients:
+ benjamin.peterson, rhettinger, gregory.p.smith, exarkun, amaury.forgeotdarc, pitrou, giampaolo.rodola, christian.heimes, ajaksu2, wplappert, ialbert |
2009-03-03 21:47:43 | benjamin.peterson | link | issue4565 messages |
2009-03-03 21:47:42 | benjamin.peterson | create | |
|