Author akuchling
Recipients akuchling, loewis, techtonik, zhirsch
Date 2009-02-26.22:22:59
SpamBayes Score 1.2567e-09
Marked as misclassified No
Message-id <1235686982.75.0.94739609563.issue2889@psf.upfronthosting.co.za>
In-reply-to
Content
I can't say anything about the Windows build aspects.  Some observations
about the curses/test_curses changes:

* test_curses: I'd be happier to see the 'if' statement as sys.platform
!= 'win32' and (not term or term == 'unknown')  -- easier to read.

* test_curses: does putp() make PDCurses crash, or is it not available?
 If the latter, I'd prefer to see 'if hasattr(curses, "putp"): <putp
test>'.    Same for the tparm() test.

* Given that you include term.h and IRIX included term.h, I wonder if we
should make _cursesmodule.c include term.h on all platforms that have
it, and then fix the resulting breakage claimed by the comment (if any).

* Is setupterm() a no-up on Windows?  Maybe the function just shouldn't
be defined on Windows, then, so that user code can check for the
function's existence.
History
Date User Action Args
2009-02-26 22:23:03akuchlingsetrecipients: + akuchling, loewis, techtonik, zhirsch
2009-02-26 22:23:02akuchlingsetmessageid: <1235686982.75.0.94739609563.issue2889@psf.upfronthosting.co.za>
2009-02-26 22:23:00akuchlinglinkissue2889 messages
2009-02-26 22:22:59akuchlingcreate