This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients LambertDW, Rhamphoryncus, chemacortes, jcea, mark.dickinson, pitrou, rhettinger
Date 2009-02-12.08:57:24
SpamBayes Score 9.95039e-08
Marked as misclassified No
Message-id <1234429046.69.0.362401801997.issue5186@psf.upfronthosting.co.za>
In-reply-to
Content
> > - avoids comparing an unsigned long to -1

Just out of interest, why?  The cast is unnecessary:  there's no ambiguity 
or undefinedness (the int -1 gets promoted to unsigned long, with 
wraparound semantics), and neither gcc nor MSVC complains.

Other than that, the patch looks fine to me;  x ^= x >> 4 would be fine  
too.  I really don't see that it makes much difference either way, since 
both transformations are reversible and fast enough.
History
Date User Action Args
2009-02-12 08:57:27mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, jcea, chemacortes, Rhamphoryncus, pitrou, LambertDW
2009-02-12 08:57:26mark.dickinsonsetmessageid: <1234429046.69.0.362401801997.issue5186@psf.upfronthosting.co.za>
2009-02-12 08:57:25mark.dickinsonlinkissue5186 messages
2009-02-12 08:57:24mark.dickinsoncreate