Author drj
Recipients drj, gpolo
Date 2009-02-11.20:34:14
SpamBayes Score 1.51907e-07
Marked as misclassified No
Message-id <508452C8-B3C8-4ECE-9AFC-B4FCD4AE91FC@pobox.com>
In-reply-to <201829EA-2F63-4889-9F9E-97CD59A4CAEE@pobox.com>
Content
On 10 Feb 2009, at 21:15, David Jones wrote:

>
> David Jones <drj@pobox.com> added the comment:
>
> On 10 Feb 2009, at 16:57, Guilherme Polo wrote:
>
>>
>> Guilherme Polo <ggpolo@gmail.com> added the comment:
>>
>> Now, is there some problem if we remove the calls to the "tell"  
>> method
>> in _write_header ? See patch attached (tests are very welcome too).
>
> Yes

Ahem.  Pardon me for answering you without reading your patch.  I  
have now read your patch and it does more than just remove the calls  
to "tell".  In fact it looks very fine.

It makes wave.py more like sunau.py in that it "just knows" what the  
offsets into the header are.  I think I like that (especially the way  
you use the struct format string to compute the second offset).  It  
also removes that nagging question at the back of my mind: "why does  
wave.py use tell when it could simply just know the offsets, which  
are constant anyway?".

And it works.  How cool is that?  I had changed my project to use  
sunau anyway, because that worked with pipes already.

Tests, you say...
History
Date User Action Args
2009-02-11 20:34:16drjsetrecipients: + drj, gpolo
2009-02-11 20:34:15drjlinkissue5202 messages
2009-02-11 20:34:14drjcreate