Author ajaksu2
Recipients ajaksu2, eelis, tarek
Date 2009-02-09.23:57:44
SpamBayes Score 3.56409e-08
Marked as misclassified No
Message-id <1234223869.3.0.622066844642.issue1112955@psf.upfronthosting.co.za>
In-reply-to
Content
Here's a very simple-minded patch (with microtest) that changes behavior
in a questionable way.

If it goes in as-is, dry_run=1 will not always succeed anymore. So it'd
be incompatible... but a 1:1 representation of a real move kinda
requires some failure mode.

It's possible to avoid raising when dry_run=1, logging a warning that a
real move would fail, and return the imaginary new full name. Or return
None, '', etc. Suggestions?

Perhaps studying a use-case makes things clearer. 

Looks like copy_file already has the same return value independent of
dry_run.
History
Date User Action Args
2009-02-09 23:57:49ajaksu2setrecipients: + ajaksu2, tarek, eelis
2009-02-09 23:57:49ajaksu2setmessageid: <1234223869.3.0.622066844642.issue1112955@psf.upfronthosting.co.za>
2009-02-09 23:57:47ajaksu2linkissue1112955 messages
2009-02-09 23:57:46ajaksu2create