Message81473
Besides the fact that this is probably great work, I really wonder who
will have enough time and skills to review such a huge patch... :-S
In any case, some recommendations:
- please provide patches against trunk; there is no way such big changes
will get committed against 2.6, which is in maintenance mode
- avoid, as far as possible, doing changes in style, whitespace or
indentation; this will make the patch slightly smaller or cleaner
- avoid C++-style comments (use /* ... */ instead)
- don't hesitate to add extensive comments and documentation about what
you've added
Once you think your patch is ready, you may post it to
http://codereview.appspot.com/, in the hope that it makes reviewing easier. |
|
Date |
User |
Action |
Args |
2009-02-09 19:09:57 | pitrou | set | recipients:
+ pitrou, akuchling, georg.brandl, jimjjewett, amaury.forgeotdarc, nneonneo, rsc, timehorse, mark, ezio.melotti, mrabarnett, moreati |
2009-02-09 19:09:57 | pitrou | set | messageid: <1234206597.21.0.973712300136.issue2636@psf.upfronthosting.co.za> |
2009-02-09 19:09:55 | pitrou | link | issue2636 messages |
2009-02-09 19:09:54 | pitrou | create | |
|