Message80613
I don't like the change of API to PyTokenizer_FromString. I would prefer
another function like PyTokenizer_IgnoreCodingCookie() blows up when
parsing has already started.
The (char *) cast in PyTokenizer_FromString is unneeded.
You need to indent the "else" clause after you test for ignore_cookie.
I'd like to see a test that shows that byte strings still have their
cookies examined. |
|
Date |
User |
Action |
Args |
2009-01-27 03:32:54 | benjamin.peterson | set | recipients:
+ benjamin.peterson, brett.cannon, sjmachin, amaury.forgeotdarc, vstinner |
2009-01-27 03:32:54 | benjamin.peterson | set | messageid: <1233027174.65.0.0556371817649.issue4626@psf.upfronthosting.co.za> |
2009-01-27 03:32:51 | benjamin.peterson | link | issue4626 messages |
2009-01-27 03:32:50 | benjamin.peterson | create | |
|