Author belopolsky
Recipients belopolsky, tarek
Date 2009-01-21.02:27:51
SpamBayes Score 2.33361e-05
Marked as misclassified No
Message-id <1232504872.75.0.148975029046.issue4972@psf.upfronthosting.co.za>
In-reply-to
Content
Please remove the old smtplib.patch: it is confusing to have two 
attachments with the same name.  It will still be available in the 
history, so nothing will be lost.

A nit-pick: 221 is a success code (in smtp 2xx codes are successes and 
5xx are errors IIRC), so vars should be simply 'code' (or 'rc' for 
return code) and 'msg', not 'errcode' and 'errmsg'.

Your new code may leave socket open in the case when self.docmd("quit") 
raises an exception other than SMTPServerDisconnected.

BTW, I think your code will be simpler if you don't reuse quit() and 
simply call docmd("quit") and close()directly in an appropriate 
try/except/finally statement.
History
Date User Action Args
2009-01-21 02:27:52belopolskysetrecipients: + belopolsky, tarek
2009-01-21 02:27:52belopolskysetmessageid: <1232504872.75.0.148975029046.issue4972@psf.upfronthosting.co.za>
2009-01-21 02:27:52belopolskylinkissue4972 messages
2009-01-21 02:27:51belopolskycreate