Author belopolsky
Recipients belopolsky, tarek
Date 2009-01-19.18:46:11
SpamBayes Score 7.3383e-07
Marked as misclassified No
Message-id <1232390773.1.0.213172759967.issue4972@psf.upfronthosting.co.za>
In-reply-to
Content
What is the rationale for swallowing all socket exceptions except 
"Connection reset by peer" in __exit__? In any case, it is better to use errno.ECONNRESET instead of literal 54.

Note that SMTP.quit() calls SMTP.close(), so in the normal termination 
case, close will be called twice.  This is not a real problem since SMTP.close() is a noop on a closed SMTP object, but it does not look 
right.

The double call to close() also makes error path harder to analyze.  It 
appears that if a socket error is raised in the first call to close, it 
gets caught only to be raised again in the second call (assuming a 
persistent error).
History
Date User Action Args
2009-01-19 18:46:13belopolskysetrecipients: + belopolsky, tarek
2009-01-19 18:46:13belopolskysetmessageid: <1232390773.1.0.213172759967.issue4972@psf.upfronthosting.co.za>
2009-01-19 18:46:12belopolskylinkissue4972 messages
2009-01-19 18:46:11belopolskycreate