Author jyasskin
Recipients collinwinter, jyasskin, pitrou, rhettinger
Date 2009-01-14.05:50:17
SpamBayes Score 0.00228858
Marked as misclassified No
Message-id <1231912219.2.0.741538103865.issue4715@psf.upfronthosting.co.za>
In-reply-to
Content
In peephole.c:

_optimize isn't a great label name, but I don't have a great
replacement. Maybe reoptimize_current_index?

Your change to the "LOAD_CONST trueconst JUMP_IF_FALSE xx POP_TOP"
optimization doesn't preserve the optimization to:
  def f():
    return 1 and a
I suspect we don't care since "0 or a" wasn't optimized.

I wonder what the "POP_TOP JUMP_FORWARD 1 POP_TOP" was ever for. Why did
compiler_comprehension_generator() emit it in the first place?

After "if (JUMP_SIGN(j) == JUMP_SIGN(opcode)) {", it might be nice to
have a comment like, "/* The second jump will always be taken if the
first was. */" and similarly for the else branch with an explanation why
the POP should become unconditional.

Otherwise looks good.
History
Date User Action Args
2009-01-14 05:50:19jyasskinsetrecipients: + jyasskin, collinwinter, rhettinger, pitrou
2009-01-14 05:50:19jyasskinsetmessageid: <1231912219.2.0.741538103865.issue4715@psf.upfronthosting.co.za>
2009-01-14 05:50:18jyasskinlinkissue4715 messages
2009-01-14 05:50:17jyasskincreate