This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jimjjewett
Recipients gvanrossum, jimjjewett, jyasskin, rhettinger, skip.montanaro
Date 2009-01-13.17:19:07
SpamBayes Score 0.27614164
Marked as misclassified No
Message-id <1231867149.1.0.0312891211179.issue4888@psf.upfronthosting.co.za>
In-reply-to
Content
I agree with Raymond.  A comment *might* be sufficient, but ... in some 
sense, that is the purpose of an assert.

The loop is reasonably long; it already includes macros which could 
(but currently don't) change the value, and function calls which might 
plausibly (but don't) reset a "why" variable.  The why variable is 
techically local, but the scope is still pretty large, so that isn't 
clear at first.

It took me some work to verify the assertion, and I'm not at all 
confident that a later change wouldn't violate it.  Nor am I confident 
that the symptoms would make for straightforward debugging.  (Would it 
look like stack corruption?  Would it take several more opcodes before 
a problem was visible?)
History
Date User Action Args
2009-01-13 17:19:09jimjjewettsetrecipients: + jimjjewett, gvanrossum, skip.montanaro, rhettinger, jyasskin
2009-01-13 17:19:09jimjjewettsetmessageid: <1231867149.1.0.0312891211179.issue4888@psf.upfronthosting.co.za>
2009-01-13 17:19:08jimjjewettlinkissue4888 messages
2009-01-13 17:19:07jimjjewettcreate