Author eckhardt
Recipients eckhardt, loewis
Date 2009-01-11.20:05:23
SpamBayes Score 0.0413483
Marked as misclassified No
Message-id <1231704324.93.0.216806586561.issue4915@psf.upfronthosting.co.za>
In-reply-to
Content
I don't really know what happens when you try to read()/fread() from 
stdin that is a directory, but I guess it will fail quickly even 
without an explicit check by Python. A directory can be opened under 
win32 just like a file, so I guess that you could also set one as 
stdin for a process. All in all, I don't care whether the check is 
made or not, but it doesn't hurt to be there either.

I'll submit a changed patch that has the opening curly brackets 
outside the conditional code. Thanks for the review, Martin, I 
appreciate your support on this.
History
Date User Action Args
2009-01-11 20:05:25eckhardtsetrecipients: + eckhardt, loewis
2009-01-11 20:05:24eckhardtsetmessageid: <1231704324.93.0.216806586561.issue4915@psf.upfronthosting.co.za>
2009-01-11 20:05:24eckhardtlinkissue4915 messages
2009-01-11 20:05:23eckhardtcreate