Author loewis
Recipients belopolsky, lemburg, loewis
Date 2009-01-07.18:43:07
SpamBayes Score 0.0430516
Marked as misclassified No
Message-id <4964F7B9.3080906@v.loewis.de>
In-reply-to <d38f5330901070749h44ae6b4bk18948db57b435156@mail.gmail.com>
Content
> My main interest in this patch are the type and %d to %zd change, but
> by throwing in the name change, I unintentionally made it more
> controversial.   Would it help if I resubmit the patch without name
> changes or is this something that a committer can take care of if the
> patch is partially accepted?

I think it is indeed better to focus on this part of the patch only.

I just reviewed it, and I think it is incorrect: We cannot assume that
the CRT supports %zd, therefore, PY_FORMAT_SIZE_T has to be used.

I fixed it, and removed the _Py_ prefixing, and committed the result
as r68381.

> Also a grep through nm output that Marc-Andre did is a good check to
> run from time to time and there is no reason to have false positives.

make smelly
History
Date User Action Args
2009-01-07 18:43:08loewissetrecipients: + loewis, lemburg, belopolsky
2009-01-07 18:43:07loewislinkissue4850 messages
2009-01-07 18:43:07loewiscreate