Message79213
from #python-dev discussion.
agreed, magic attributes are annoying. also, my gps05 patch continues
to return the old fileno even after the underlying socket has been
closed. that is a problem.
I like your patch in #4791 but lets keep both sets of our unit tests.
Also, I think the SocketIO.fileno mathod should change to:
def fileno(self):
no = self._sock.fileno()
if no == -1:
raise IOError("no file descriptor, socket is closed.")
io.IOBase.fileno already raises IOError when no file descriptor is
associated with a file so this behavior seems reasonable and more
pythonic than returning a magic -1.
thoughts? |
|
Date |
User |
Action |
Args |
2009-01-05 23:29:47 | gregory.p.smith | set | recipients:
+ gregory.p.smith, gvanrossum, loewis, jhylton, amaury.forgeotdarc, ggenellina, vstinner, zanella, romkyns |
2009-01-05 23:29:47 | gregory.p.smith | set | messageid: <1231198187.71.0.537669615904.issue3826@psf.upfronthosting.co.za> |
2009-01-05 23:29:47 | gregory.p.smith | link | issue3826 messages |
2009-01-05 23:29:46 | gregory.p.smith | create | |
|