Author pitrou
Recipients amaury.forgeotdarc, christian.heimes, kristjan.jonsson, pitrou
Date 2009-01-05.14:56:17
SpamBayes Score 0.0151287
Marked as misclassified No
Message-id <1231167378.53.0.129777968454.issue4293@psf.upfronthosting.co.za>
In-reply-to
Content
A few comments about the test:
- it should be a method of TestCAPI; we try to unittest everywhere,
although there is some old code which predates that
- the implementation would be stressed better if each callback was added
from a separate thread, rather than adding them all at once; it will
also make the C function in _testcapi simpler (and you can do the sleep
in the Python code in test_capi.py)
- if you want the list operation in your callback to be atomic, it
should append() something to the list rather than increment its first
element; then you just have to test for the len() of the list
- in _pending_callback(), you must use Py_XDECREF(r), not Py_DECREF,
since r can be NULL

I will look at the ceval part of the patch later :)
History
Date User Action Args
2009-01-05 14:56:18pitrousetrecipients: + pitrou, amaury.forgeotdarc, kristjan.jonsson, christian.heimes
2009-01-05 14:56:18pitrousetmessageid: <1231167378.53.0.129777968454.issue4293@psf.upfronthosting.co.za>
2009-01-05 14:56:17pitroulinkissue4293 messages
2009-01-05 14:56:17pitroucreate