This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients ajaksu2, gpolo, loewis, pitrou, vstinner
Date 2009-01-03.14:10:01
SpamBayes Score 2.3653176e-06
Marked as misclassified No
Message-id <495F71B7.6080600@v.loewis.de>
In-reply-to <1230991215.35.0.664074846446.issue3638@psf.upfronthosting.co.za>
Content
> Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the 
> module in Python 3.x. New attached patch uses PyModule_Check() to 
> check if selfptr is the module or an object.

The patch looks right in principle. Please make sure not to include
printf calls in it.

Please also consider all similar cases, such as Tkapp_CreateFileHandler.

>> if that function is removed, the code to support 
>> it should also be removed.
> 
> Which code? 

The code inside the function: all tests whether self is NULL. If
mainloop would stop being a module function, this code also should go.
History
Date User Action Args
2009-01-03 14:10:02loewissetrecipients: + loewis, pitrou, vstinner, ajaksu2, gpolo
2009-01-03 14:10:01loewislinkissue3638 messages
2009-01-03 14:10:01loewiscreate