Author vstinner
Recipients ebfe, pitrou, vstinner
Date 2008-12-27.01:38:06
SpamBayes Score 9.19692e-08
Marked as misclassified No
Message-id <1230341887.32.0.0265447410962.issue4738@psf.upfronthosting.co.za>
In-reply-to
Content
Comments on zlib_threads-2.diff:
 - the indentation is strange: don't mix spaces and tabs!
 - I prefer ";" after a call to a macro: "ENTER_ZLIB(self);" instead 
of "ENTER_ZLIB(self)". It makes vim happy (auto indent code correctly) 
and it works for ENTER_ZLIB and LEAVER_ZLIB.
 - ENTER_ZLIB and LEAVER_ZLIB prototype is wrong if WITH_THREAD is not 
defined
 - oh yeah, s* is needed to protect the buffer with a lock
 - why 5kb? is it a random value? I prefer power of two, like 4096 
bytes :-)
History
Date User Action Args
2008-12-27 01:38:07vstinnersetrecipients: + vstinner, pitrou, ebfe
2008-12-27 01:38:07vstinnersetmessageid: <1230341887.32.0.0265447410962.issue4738@psf.upfronthosting.co.za>
2008-12-27 01:38:06vstinnerlinkissue4738 messages
2008-12-27 01:38:06vstinnercreate