This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gpolo
Recipients gpolo, loewis, pysquared
Date 2008-12-17.02:05:03
SpamBayes Score 4.29811e-08
Marked as misclassified No
Message-id <>
Something like the proposed patch is still needed. But allow me to point
out my views towards your current patch:

* Changes in Misc.after, Misc._bind: good

* Changes in Misc.unbind can be simplified a bit:

cbs = self._bind_names(self._bind(('bind', self._w), sequence,
func=None, add=None))

could be only:

cbs = self._bind_names(self.bind(sequence))

and the comment in the end should go.

* Changes in Misc.unbind_all and Misc.unbind_class can be simplified in
the same as as Misc.unbind (just change self.bind by self.bind_all and

* Changes in Variable: would you care to elaborate more on these ? Do
you need a new _tclCommands there and also use the _tclCommands from its
master ?

* Changes in Misc._options are somewhat fine. 
 - The comment about Python 2.3, 2.4, 2.5 being bugged because a Tcl_Obj
is returned is misleading, so you should change it.
 - What are you gaining by sorting the cnf keys ?

* Changes in Misc._configure uhm.. it is hard to like that one =) Since
we are after commands created, why can't we just check the _tclCommands
before and after calling tcl here ? So we just remove the difference
(maybe move it to a set?) and don't do all those checks in case of
error, and then reraise the error.

* Changes in Wm.wm_protocol: I almost like it, except that there are two
checks for a callable arg now.

Hopefully you are still around.
Date User Action Args
2008-12-17 02:05:05gpolosetrecipients: + gpolo, loewis, pysquared
2008-12-17 02:05:05gpolosetmessageid: <>
2008-12-17 02:05:04gpololinkissue1524639 messages
2008-12-17 02:05:03gpolocreate