This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients Nick Barnes, ggenellina, lemburg, pitrou, vstinner
Date 2008-12-16.21:03:34
SpamBayes Score 5.80419e-08
Marked as misclassified No
Message-id <1229461415.65.0.211508351028.issue4426@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not in a position to comment on the encoding algorithm itself but I
have a couple of comments:

* I get the following compilation warning:
Objects/unicodeobject.c: In function ‘PyUnicode_DecodeUTF7Stateful’:
Objects/unicodeobject.c:1531: attention : ‘shiftOutStart’ may be used
uninitialized in this function

* shouldn't there be an additional test for the '/' behaviour (unless it
is already there and I have overlooked it)?

* your patch fails on another test:
Traceback (most recent call last):
  File "Lib/test/test_unicode.py", line 538, in test_codecs_utf7
    self.assertRaises(UnicodeDecodeError, '+\xc1'.decode, 'utf-7')
AssertionError: UnicodeDecodeError not raised
History
Date User Action Args
2008-12-16 21:03:35pitrousetrecipients: + pitrou, lemburg, ggenellina, vstinner, Nick Barnes
2008-12-16 21:03:35pitrousetmessageid: <1229461415.65.0.211508351028.issue4426@psf.upfronthosting.co.za>
2008-12-16 21:03:35pitroulinkissue4426 messages
2008-12-16 21:03:34pitroucreate