Message77933
I'm not in a position to comment on the encoding algorithm itself but I
have a couple of comments:
* I get the following compilation warning:
Objects/unicodeobject.c: In function ‘PyUnicode_DecodeUTF7Stateful’:
Objects/unicodeobject.c:1531: attention : ‘shiftOutStart’ may be used
uninitialized in this function
* shouldn't there be an additional test for the '/' behaviour (unless it
is already there and I have overlooked it)?
* your patch fails on another test:
Traceback (most recent call last):
File "Lib/test/test_unicode.py", line 538, in test_codecs_utf7
self.assertRaises(UnicodeDecodeError, '+\xc1'.decode, 'utf-7')
AssertionError: UnicodeDecodeError not raised |
|
Date |
User |
Action |
Args |
2008-12-16 21:03:35 | pitrou | set | recipients:
+ pitrou, lemburg, ggenellina, vstinner, Nick Barnes |
2008-12-16 21:03:35 | pitrou | set | messageid: <1229461415.65.0.211508351028.issue4426@psf.upfronthosting.co.za> |
2008-12-16 21:03:35 | pitrou | link | issue4426 messages |
2008-12-16 21:03:34 | pitrou | create | |
|