➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jyasskin
Recipients amaury.forgeotdarc, jyasskin
Date 2008-12-08.16:40:17
SpamBayes Score 1.5145882e-06
Marked as misclassified No
Message-id <1228754419.06.0.475982879058.issue4589@psf.upfronthosting.co.za>
In-reply-to
Content 
I think your patch leaks a reference to 'x'. Move the Py_DECREF(x) to
before "if (err < 0)"?

And then really nitpicky: your test has 3 blank lines after it, and
should have 2.

Otherwise looks great. Thanks for picking this up!
History
Date User Action Args
2008-12-08 16:40:19jyasskinsetrecipients: + jyasskin, amaury.forgeotdarc
2008-12-08 16:40:19jyasskinsetmessageid: <1228754419.06.0.475982879058.issue4589@psf.upfronthosting.co.za>
2008-12-08 16:40:18jyasskinlinkissue4589 messages
2008-12-08 16:40:18jyasskincreate