Author skip.montanaro
Recipients mark.dickinson, skip.montanaro
Date 2008-12-06.19:03:43
SpamBayes Score 5.75439e-05
Marked as misclassified No
Message-id <1228590225.01.0.948897246133.issue4506@psf.upfronthosting.co.za>
In-reply-to
Content
> can you come up with a configure patch that would allow isinf to be
> detected on Solaris?

The plot thickens.  I know squat about autoconf sorts of things so I
asked on the autoconf mailing list.  Eric Drake responded (in part):

  The Python ACHECK_FUNCS test should be rewritten (with proper m4
  quoting) as:

  AC_CHECK_FUNCS([acosh asinh atanh expm1 finite log1p])
  AC_CHECK_DECLS([isinf, isnan], [], [], [[#include <math.h>]])

so I gave that a whirl.  Whaddya know?  isinf *really* isn't available,
at least not until C99 apparently.  The AC_CHECK_DECLS macro generates
a conftest.c which looks like this:

  #include <math.h> 
 
  int 
  main () 
  { 
  #ifndef isinf 
    (void) isinf; 
  #endif 
 
    ; 
    return 0; 
  } 

which fails to compile/link on our Sol10 boxes.  Turns out libm.so
doesn't export an _isinf symbol.  The macro I found (in iso/math_c99.h)
doesn't expand in gcc -E output of the above code, so in my non-c99
environment I don't get to use isinf.  Looks like your Py_IS_INFINITY
fix will be necessary.  Eric also suggested using the gnu isinf and
isnan modules:

  http://git.savannah.gnu.org/gitweb/?
p=gnulib.git;a=blob;f=m4/isinf.m4;h=1b9e45a;hb=67461c3

I'll leave that for you to decide.

In any case, the above changes to AC_CHECK_FUNCS should probably be
made.

Skip
History
Date User Action Args
2008-12-06 19:03:45skip.montanarosetrecipients: + skip.montanaro, mark.dickinson
2008-12-06 19:03:45skip.montanarosetmessageid: <1228590225.01.0.948897246133.issue4506@psf.upfronthosting.co.za>
2008-12-06 19:03:44skip.montanarolinkissue4506 messages
2008-12-06 19:03:43skip.montanarocreate