This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lemburg
Recipients apaprocki, barry, christian.heimes, drj, georg.brandl, lemburg
Date 2008-12-03.10:20:02
SpamBayes Score 7.13508e-07
Marked as misclassified No
Message-id <49365D4E.60106@egenix.com>
In-reply-to <1228265068.75.0.532956759594.issue4025@psf.upfronthosting.co.za>
Content
On 2008-12-03 01:44, Christian Heimes wrote:
> Christian Heimes <lists@cheimes.de> added the comment:
> 
> Barry, the issue in _ctypes/callproc.c could be a problem for us
> although Python 2.6 and 3.0 are compiling fine with -std=c89. Should the
> comment be fixed before the release?

I had a second look at the code. That comment is in #ifdefs:

#ifdef MS_WIN32
...
#endif

so it won't affect compiling ctypes on Unix platforms.

Still, I find the situation with C99 comments scattered around the
source code less than ideal. Either we officially abandon C90 and move
on to C99 or we stick to C90 for all source code (including code that
only gets compiled on Macs or MSVC).

It's just too easy for a C99 comment to slip into code that's
targeted for non-gcc/non-MSVC compilers as well and these then
break the portability of Python to those compilers/platforms.
History
Date User Action Args
2008-12-03 10:20:04lemburgsetrecipients: + lemburg, barry, georg.brandl, christian.heimes, drj, apaprocki
2008-12-03 10:20:03lemburglinkissue4025 messages
2008-12-03 10:20:02lemburgcreate