Author vstinner
Recipients giampaolo.rodola, lcatucci, vstinner
Date 2008-12-01.23:05:55
SpamBayes Score 6.34106e-09
Marked as misclassified No
Message-id <1228172756.95.0.162652807784.issue4471@psf.upfronthosting.co.za>
In-reply-to
Content
Same comments than issue #4473:
- you might split your patch into smaller patches
- Do you really need to keep a reference to the "raw" socket?
- I don't understand what is sock.shutdown(SHUT_RDWR). When is it 
needed? Does it change the behaviour?

Oh, another comment:
- When I fixed poplib/imaplib in py3k, I created a _create_socket() 
method which to factorize the "classic" class and the SSL class. The 
classic class uses socket.create_connection() which supports IPv4 and 
IPv6 (and maybe other protocols) whereas the SSL version reimplements 
create_connection(): "for ... in getaddrinfo...". So you may reuse 
this idea for in your SSL refactoring (for POP3 and IMAP4).
History
Date User Action Args
2008-12-01 23:05:57vstinnersetrecipients: + vstinner, giampaolo.rodola, lcatucci
2008-12-01 23:05:56vstinnersetmessageid: <1228172756.95.0.162652807784.issue4471@psf.upfronthosting.co.za>
2008-12-01 23:05:56vstinnerlinkissue4471 messages
2008-12-01 23:05:56vstinnercreate