This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lcatucci
Recipients lcatucci
Date 2008-11-30.16:23:27
SpamBayes Score 1.7295449e-06
Marked as misclassified No
Message-id <1228062214.03.0.955455415588.issue4470@psf.upfronthosting.co.za>
In-reply-to
Content
The enclosed patch does three things:
1. enables SMTP_SSL working: the _get_socket method was setting
   self.sock instead of returning the socket to the caller, which
   did reset self.sock to None
2. replace home-grown SSLFakeFile() with calls to ssl.socket's makefile()
   calls both in the starttls and in the SMTP_SSL cases
3. shutdown sockets before closing them, to avoid server-side piling and
   connection refused on connection-limited servers
The last change is just a cosmetical refactoring, but it really helps
the SMTP_SSL case: default_port should really be a class attribute,
instead of being set at __init__ time.
History
Date User Action Args
2008-11-30 16:23:34lcatuccisetrecipients: + lcatucci
2008-11-30 16:23:34lcatuccisetmessageid: <1228062214.03.0.955455415588.issue4470@psf.upfronthosting.co.za>
2008-11-30 16:23:33lcatuccilinkissue4470 messages
2008-11-30 16:23:30lcatuccicreate