This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients benjamin.peterson, loewis
Date 2008-11-25.23:10:10
SpamBayes Score 8.305547e-09
Marked as misclassified No
Message-id <492C85D0.1010603@v.loewis.de>
In-reply-to <1227653200.02.0.857098785961.issue4423@psf.upfronthosting.co.za>
Content
> I'm not sure what you mean about MAPPING being compiled in. It is
> regenerated every time 2to3 is run.

This code does not work:

    from lib2to3.fixes import fix_imports
    del fix_imports.MAPPING['commands']

when followed by an attempt to actually run the fixer. Instead, I need
to write

    from lib2to3.fixes import fix_imports
    del fix_imports.MAPPING['commands']
    fix_imports.FixImports.PATTERN="|".join(fix_imports.build_pattern())

> Anyway, I fixed the replacement problem in r67386.

Thanks! It still transforms

def g():
    import commands
def f():
    commands = foo()
    commands.sort()

but I think this is ok; people just shouldn't write such code in the
first place (and the resulting code does work correctly - just with
a strangely-renamed local variable).
History
Date User Action Args
2008-11-25 23:10:12loewissetrecipients: + loewis, benjamin.peterson
2008-11-25 23:10:11loewislinkissue4423 messages
2008-11-25 23:10:10loewiscreate